linux-kernel - Re: [PATCH v4 03/13] x86/platform/uv: Adjust references in UV kernel modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7598f508-6c4a-f1df-f83f-2f68bc99578f@hpe.com>
Date:   Mon, 5 Oct 2020 14:32:38 -0700
From:   Mike Travis <mike.travis@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        Steve Wahl <steve.wahl@....com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Russ Anderson <russ.anderson@....com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Jian Cai <caij2003@...il.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v4 03/13] x86/platform/uv: Adjust references in UV kernel
 modules



On 10/5/2020 2:16 PM, Borislav Petkov wrote:
> On Mon, Oct 05, 2020 at 03:39:19PM -0500, Mike Travis wrote:
>> Make a small symbol change (is_uv() ==> is_uv_sys()) to accommodate a
>> change in the uv_mmrs.h file (is_uv() is the new arch selector function).
>>
>> Signed-off-by: Mike Travis <mike.travis@....com>
>> Reviewed-by: Dimitri Sivanich <dimitri.sivanich@....com>
>> Reviewed-by: Steve Wahl <steve.wahl@....com>
>> ---
>>   drivers/misc/sgi-xp/xp.h            | 8 ++++----
>>   drivers/misc/sgi-xp/xp_main.c       | 4 ++--
>>   drivers/misc/sgi-xp/xp_uv.c         | 6 ++++--
>>   drivers/misc/sgi-xp/xpc_main.c      | 6 +++---
>>   drivers/misc/sgi-xp/xpc_partition.c | 2 +-
>>   drivers/misc/sgi-xp/xpnet.c         | 2 +-
>>   6 files changed, 15 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/misc/sgi-xp/xp.h b/drivers/misc/sgi-xp/xp.h
>> index 06469b12aced..0af267baf031 100644
>> --- a/drivers/misc/sgi-xp/xp.h
>> +++ b/drivers/misc/sgi-xp/xp.h
>> @@ -17,11 +17,11 @@
>>   
>>   #if defined CONFIG_X86_UV || defined CONFIG_IA64_SGI_UV
>>   #include <asm/uv/uv.h>
>> -#define is_uv()		is_uv_system()
>> +#define is_uv_sys()		is_uv_system()
> 
> Do I see it correctly that you can simply use is_uv_system() directly
> instead of this macro indirection?

Yes, there was the MACRO is_uv() that conflicted with the automated 
"generate uv_mmrs.h" PERL script that also uses it that I changed.  I 
see now maybe just getting rid of the entire thing in this file might 
have been better?