linux-kernel - Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <brWYeL8miTAikvEPYFNe2Kpe05OBtiD6yuS6jRg1VCX-lt7ANc1B2y7AM6ECEoG9AJwZP5_5qoGO7POvK0MtruvqG8q8kHbyHiOUIZ72Klk=@protonmail.com>
Date:   Mon, 05 Oct 2020 23:19:02 +0000
From:   "Harley A.W. Lorenzo" <hl1998@...tonmail.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-safety@...ts.elisa.tech" <linux-safety@...ts.elisa.tech>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "stern@...land.harvard.edu" <stern@...land.harvard.edu>
Subject: Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference

On Monday, October 5, 2020 5:31 PM, Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:

> find_tt() can return NULL or the error value in ERR_PTR() and
> dereferencing the return value without checking for the error can
> lead to a possible dereference of NULL pointer or ERR_PTR().

Looks fine to me. There is in fact no checks of the return value
before a dereference here, and this solves that.

Reviewed-by: Harley A.W. Lorenzo <hl1998@...tonmail.com