linux-kernel - Re: [PATCH v4] net: can: Introduce MEN 16Z192-00 CAN controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202010051959.nUy99vKZ-lkp@intel.com>
Date:   Mon, 5 Oct 2020 19:08:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Abhijeet Badurkar <abhijeet.badurkar@...gon.com>,
        wg@...ndegger.com, mkl@...gutronix.de
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-can@...r.kernel.org, andreas.geissler@...gon.com,
        Abhijeet Badurkar <abhijeet.badurkar@...gon.com>
Subject: Re: [PATCH v4] net: can: Introduce MEN 16Z192-00 CAN controller
 driver

Hi Abhijeet,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 549738f15da0e5a00275977623be199fbbf7df50]

url:    https://github.com/0day-ci/linux/commits/Abhijeet-Badurkar/net-can-Introduce-MEN-16Z192-00-CAN-controller-driver/20201005-170737
base:    549738f15da0e5a00275977623be199fbbf7df50
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/52523430855158ee790d4fbce7d0ff4d3fda6fac
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Abhijeet-Badurkar/net-can-Introduce-MEN-16Z192-00-CAN-controller-driver/20201005-170737
        git checkout 52523430855158ee790d4fbce7d0ff4d3fda6fac
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/can/men_z192_can.c:924:6: warning: no previous prototype for 'men_z192_init_coalesce' [-Wmissing-prototypes]
     924 | void men_z192_init_coalesce(struct net_device *ndev)
         |      ^~~~~~~~~~~~~~~~~~~~~~

vim +/men_z192_init_coalesce +924 drivers/net/can/men_z192_can.c

   923	
 > 924	void men_z192_init_coalesce(struct net_device *ndev)
   925	{
   926		men_z192_set_buf_lvl_irq(ndev, MEN_Z192_MIN_BUF_LVL,
   927					 MEN_Z192_MIN_BUF_LVL);
   928		men_z192_set_rx_tout(ndev, MEN_Z192_RX_TOUT_DEF);
   929	}
   930	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (57196 bytes)