linux-kernel - Re: [RFC PATCH] kthread: do not modify running work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201005111658.GD3673@alley>
Date:   Mon, 5 Oct 2020 13:16:58 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        tj@...nel.org, akpm@...ux-foundation.org,
        Peter Zijlstra <peterz@...radead.org>,
        Zqiang <qiang.zhang@...driver.com>
Subject: Re: [RFC PATCH] kthread: do not modify running work

On Mon 2020-10-05 10:38:29, Petr Mladek wrote:
> On Sun 2020-10-04 10:12:13, Hillf Danton wrote:
> > On Fri, 02 Oct 2020 10:32:32 Thomas Gleixner wrote:
> > > So having a consistent behaviour accross all these facilities makes
> > > absolutely sense and I don't agree with your sentiment in the changelog
> > > at all.
> > > 
> > > Just because it does not make sense to you is not a justification for
> > > making stuff inconsistent. You still have not provided a technical
> > > reason why this change is needed.
> > 
> > Given the queue method, it is no win to modify delayed work from callback
> > in any case because "we are not adding interfaces just because we can."
> 
> What about ipmi_kthread_worker_func()? It is delayed work that
> queues itself.

The function name is actually mv88e6xxx_irq_poll() in upstream.

The wrong name came from a patch when I worked on the API and
tried to switch some kthreads to it.

Best Regards,
Petr