linux-kernel - Re: [PATCH] arm64: dts: ti: k3-j7200-main: Add McASP nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201005115805.d6yhykn7oc6x2tbu@charm>
Date:   Mon, 5 Oct 2020 06:58:05 -0500
From:   Nishanth Menon <nm@...com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>
CC:     <t-kristo@...com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <robh+dt@...nel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-j7200-main: Add McASP nodes

On 10:48-20201005, Peter Ujfalusi wrote:
> Add the nodes for McASP 0-2 and keep them disabled because several
> required properties are not present as they are board specific.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 57 +++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> index 72d6496e88dd..cc6c2a81887a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> @@ -446,4 +446,61 @@ usb0: usb@...0000 {
>  			dr_mode = "otg";
>  		};
>  	};
> +
> +	mcasp0: mcasp@...00000 {
> +		compatible = "ti,am33xx-mcasp-audio";
> +		reg = <0x0 0x02b00000 0x0 0x2000>,
> +			<0x0 0x02b08000 0x0 0x1000>;
> +		reg-names = "mpu","dat";
> +		interrupts = <GIC_SPI 544 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 545 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "tx", "rx";
> +
> +		dmas = <&main_udmap 0xc400>, <&main_udmap 0x4400>;
> +		dma-names = "tx", "rx";
> +
> +		clocks = <&k3_clks 174 40>;
> +		clock-names = "fck";
> +		power-domains = <&k3_pds 174 TI_SCI_PD_EXCLUSIVE>;
> +
> +		status = "disabled";

I see that there is inconsistent usage of "disabled" in our SoC.dts

Our generic rule has been set them to disabled in board.dtsi
McASP and DSS for existing SoC dts do not follow this.. which is a tad
confusing.. (considering that not even all uarts come out on every board
and every uart needs pinmux to function..)

Tero: Thoughts?

[...]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D