lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Oct 2020 14:15:34 +0200 From: David Hildenbrand <david@...hat.com> To: linux-kernel@...r.kernel.org Cc: linux-mm@...ck.org, linux-hyperv@...r.kernel.org, xen-devel@...ts.xenproject.org, linux-acpi@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Matthew Wilcox <willy@...radead.org>, David Hildenbrand <david@...hat.com>, Wei Yang <richard.weiyang@...ux.alibaba.com>, Michal Hocko <mhocko@...e.com>, Alexander Duyck <alexander.h.duyck@...ux.intel.com>, Mel Gorman <mgorman@...hsingularity.net>, Michal Hocko <mhocko@...nel.org>, Dave Hansen <dave.hansen@...el.com>, Vlastimil Babka <vbabka@...e.cz>, Oscar Salvador <osalvador@...e.de>, Mike Rapoport <rppt@...nel.org>, Pankaj Gupta <pankaj.gupta.linux@...il.com> Subject: [PATCH v2 5/5] mm/memory_hotplug: update comment regarding zone shuffling As we no longer shuffle via generic_online_page() and when undoing isolation, we can simplify the comment. We now effectively shuffle only once (properly) when onlining new memory. Reviewed-by: Wei Yang <richard.weiyang@...ux.alibaba.com> Acked-by: Michal Hocko <mhocko@...e.com> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Alexander Duyck <alexander.h.duyck@...ux.intel.com> Cc: Mel Gorman <mgorman@...hsingularity.net> Cc: Michal Hocko <mhocko@...nel.org> Cc: Dave Hansen <dave.hansen@...el.com> Cc: Vlastimil Babka <vbabka@...e.cz> Cc: Wei Yang <richard.weiyang@...ux.alibaba.com> Cc: Oscar Salvador <osalvador@...e.de> Cc: Mike Rapoport <rppt@...nel.org> Cc: Pankaj Gupta <pankaj.gupta.linux@...il.com> Signed-off-by: David Hildenbrand <david@...hat.com> --- mm/memory_hotplug.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 03a00cb68bf7..b44d4c7ba73b 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -858,13 +858,10 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, undo_isolate_page_range(pfn, pfn + nr_pages, MIGRATE_MOVABLE); /* - * When exposing larger, physically contiguous memory areas to the - * buddy, shuffling in the buddy (when freeing onlined pages, putting - * them either to the head or the tail of the freelist) is only helpful - * for maintaining the shuffle, but not for creating the initial - * shuffle. Shuffle the whole zone to make sure the just onlined pages - * are properly distributed across the whole freelist. Make sure to - * shuffle once pageblocks are no longer isolated. + * Freshly onlined pages aren't shuffled (e.g., all pages are placed to + * the tail of the freelist when undoing isolation). Shuffle the whole + * zone to make sure the just onlined pages are properly distributed + * across the whole freelist - to create an initial shuffle. */ shuffle_zone(zone); -- 2.26.2
Powered by blists - more mailing lists