linux-kernel - Re: [PATCH v2] regmap: irq: Add support to clear ack registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5e5f874f2cd42d2b639a5556bd67136@codeaurora.org>
Date:   Mon, 05 Oct 2020 19:32:34 +0530
From:   b_lkasam@...eaurora.org
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     broonie@...nel.org, rafael@...nel.org,
        linux-kernel@...r.kernel.org, srinivas.kandagatla@...aro.org
Subject: Re: [PATCH v2] regmap: irq: Add support to clear ack registers

On 2020-10-05 18:11, Greg KH wrote:
> On Mon, Oct 05, 2020 at 05:55:27PM +0530, b_lkasam@...eaurora.org 
> wrote:
>> <diff in v1 to v2 , addressed formatting and simplified logic >
> 
> That goes below the --- line, as the documentation says, right?
> 
> And this whole thing was attached, twice, why?  Can't you use 'git 
> send-email'?
> 
Sure, will fix it and send via git mail option, also will update below
commit text to use upto 72 columns.

>> For particular codec HWs have requirement to
>> toggle interrupt clear register twice 0->1->0.
>> To accommodate it, need to add one more field
>> (clear_ack) in the regmap_irq struct and update
>> regmap-irq driver to support it.
> 
> Nit, we have 72 columns to fill, might as well use it :)
> 
> thanks,
> 
> greg k-h