linux-kernel - Re: [RFC PATCH v4 4/4] objtool: fix x86 orc generation on big endian cross compiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201005140328.hpbpkfpx3hmpuapt@treble>
Date:   Mon, 5 Oct 2020 09:03:28 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Vasily Gorbik <gor@...ux.ibm.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        David Laight <David.Laight@...lab.com>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Miroslav Benes <mbenes@...e.cz>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Julien Thierry <jthierry@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v4 4/4] objtool: fix x86 orc generation on big endian
 cross compiles

On Sun, Oct 04, 2020 at 04:30:54PM +0200, Vasily Gorbik wrote:
> @@ -77,8 +78,9 @@ static int get_alt_entry(struct elf *elf, struct special_entry *entry,
>  	if (entry->feature) {
>  		unsigned short feature;
> 
> -		feature = *(unsigned short *)(sec->data->d_buf + offset +
> -					      entry->feature);
> +		feature = bswap_if_needed(*(unsigned short *)(sec->data->d_buf +
> +							      offset +
> +							      entry->feature));
>  		arch_handle_alternative(feature, alt);
>  	}
> ---
>  arch/x86/include/asm/orc_types.h              | 10 +++++
>  tools/arch/x86/include/asm/orc_types.h        | 10 +++++
>  .../arch/x86/include/arch_endianness.h        |  9 +++++
>  tools/objtool/check.c                         |  5 ++-
>  tools/objtool/endianness.h                    | 38 +++++++++++++++++++
>  tools/objtool/orc_dump.c                      |  5 ++-
>  tools/objtool/orc_gen.c                       |  3 ++
>  tools/objtool/special.c                       |  6 ++-
>  8 files changed, 80 insertions(+), 6 deletions(-)
>  create mode 100644 tools/objtool/arch/x86/include/arch_endianness.h
>  create mode 100644 tools/objtool/endianness.h
> 
> diff --git a/arch/x86/include/asm/orc_types.h b/arch/x86/include/asm/orc_types.h
> index fdbffec4cfde..5a2baf28a1dc 100644

This patch is misformatted.  Almost like it was concatenated with
itself?

-- 
Josh