lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Oct 2020 16:07:21 +0200 From: Daniel Vetter <daniel@...ll.ch> To: Rikard Falkeborn <rikard.falkeborn@...il.com> Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Andrzej Hajda <a.hajda@...sung.com>, Neil Armstrong <narmstrong@...libre.com>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...l.net>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch> Subject: Re: [PATCH] drm: bridge: dw-hdmi: Constify dw_hdmi_i2s_ops On Sun, Oct 04, 2020 at 10:06:53PM +0200, Rikard Falkeborn wrote: > The only usage of dw_hdmi_i2s_ops is to assign its address to the ops > field in the hdmi_codec_pdata struct, which is a const pointer. Make it > const to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com> Queued up in drm-misc-next for 5.11, thanks for your patch. -Daniel > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c > index 9fef6413741d..feb04f127b55 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c > @@ -170,7 +170,7 @@ static int dw_hdmi_i2s_hook_plugged_cb(struct device *dev, void *data, > return dw_hdmi_set_plugged_cb(hdmi, fn, codec_dev); > } > > -static struct hdmi_codec_ops dw_hdmi_i2s_ops = { > +static const struct hdmi_codec_ops dw_hdmi_i2s_ops = { > .hw_params = dw_hdmi_i2s_hw_params, > .audio_startup = dw_hdmi_i2s_audio_startup, > .audio_shutdown = dw_hdmi_i2s_audio_shutdown, > -- > 2.28.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Powered by blists - more mailing lists