linux-kernel - Re: [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=XLWgyS0T5h9JtNpDSo4PebUYX-YEAW9nBo5VyhKRbvYA@mail.gmail.com>
Date:   Mon, 5 Oct 2020 07:43:21 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Vignesh Raghavendra <vigneshr@...com>
Cc:     Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Michael Walle <michael@...le.cc>,
        linux-mtd@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"

Hi,

On Mon, Oct 5, 2020 at 2:03 AM Vignesh Raghavendra <vigneshr@...com> wrote:
>
> This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.
>
> This leads to warn dump like [1] on some platforms and reorders MTD
> devices thus may break user space expectations. So revert the change.
>
> [1]:
>
> [    1.849801] ------------[ cut here ]------------
> [    1.854271] mscc_felix 0000:00:00.5: device is disabled, skipping
> [    1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 __request_module+0x3a4/0x568
>
> [...]
>
> Reported-by: Michael Walle <michael@...le.cc>
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> ---
>  drivers/mtd/spi-nor/core.c | 1 -
>  1 file changed, 1 deletion(-)

Thank you for the revert and sorry for the breakage.

Reviewed-by: Douglas Anderson <dianders@...omium.org>