linux-kernel - Re: linux-next: Fixes tag needs some work in the battery tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAATdQgAjk2fjtk+yprpeftihwJpKrNUWpQaB00R9vzFLc_30Tg@mail.gmail.com>
Date:   Tue, 6 Oct 2020 12:18:25 +0800
From:   Ikjoon Jang <ikjn@...omium.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the battery tree

On Tue, Oct 6, 2020 at 11:57 AM Ikjoon Jang <ikjn@...omium.org> wrote:
>
> On Mon, Oct 5, 2020 at 7:50 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> >   f9d293364b45 ("power: supply: sbs-battery: keep error code when get_property() fails")
> >
> > Fixes tag
> >
> >   Fixes: c4f382930145 (power: supply: sbs-battery: don't assume i2c errors as battery disconnect)
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 395a7251dc2b ("power: supply: sbs-battery: don't assume i2c errors as battery disconnect")
> >
>
> Yes, you're right. I guess I made a mistake here.
> I'll send a v2 patch.

Oh I'm sorry, it's from linux-next!

I found d6e24aa0bf15 ("power: supply: sbs-battery: keep error code
when get_property() fails") on sre/for-next branch
with a valid Fixes tag:

    power: supply: sbs-battery: keep error code when get_property() fails

    Commit c4f382930145 (power: supply: sbs-battery: don't assume
    i2c errors as battery disconnect) overwrites the original error code
    returned from internal functions. On such a sporadic i2c error,
    a user will get a wrong value without errors.

    Fixes: 395a7251dc2b (power: supply: sbs-battery: don't assume i2c
errors as battery disconnect)

    Signed-off-by: Ikjoon Jang <ikjn@...omium.org>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>

but there is still a wrong sha-1 hash in the commit message,
Sebastian, can you please amend the commit message before merge?


>
> Thank you!
>
> > --
> > Cheers,
> > Stephen Rothwell