| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1601958428.26323.26.camel@mhfsdcap03>
Date: Tue, 6 Oct 2020 12:27:08 +0800
From: Yong Wu <yong.wu@...iatek.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Joerg Roedel <joro@...tes.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Robin Murphy <robin.murphy@....com>,
Will Deacon <will@...nel.org>,
Evan Green <evgreen@...omium.org>,
Tomasz Figa <tfiga@...gle.com>,
<linux-mediatek@...ts.infradead.org>,
<srv_heupstream@...iatek.com>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<iommu@...ts.linux-foundation.org>, <youlin.pei@...iatek.com>,
Nicolas Boichat <drinkcat@...omium.org>,
<anan.sun@...iatek.com>, <chao.hao@...iatek.com>,
<ming-fan.chen@...iatek.com>,
Greg Kroah-Hartman <gregkh@...gle.com>,
<kernel-team@...roid.com>
Subject: Re: [PATCH v3 02/24] dt-bindings: memory: mediatek: Convert SMI to
DT schema
On Fri, 2020-10-02 at 13:08 +0200, Krzysztof Kozlowski wrote:
> On Wed, Sep 30, 2020 at 03:06:25PM +0800, Yong Wu wrote:
> > Convert MediaTek SMI to DT schema.
> >
> > Signed-off-by: Yong Wu <yong.wu@...iatek.com>
> > ---
> > .../mediatek,smi-common.txt | 49 ---------
> > .../mediatek,smi-common.yaml | 100 ++++++++++++++++++
> > .../memory-controllers/mediatek,smi-larb.txt | 49 ---------
> > .../memory-controllers/mediatek,smi-larb.yaml | 91 ++++++++++++++++
> > 4 files changed, 191 insertions(+), 98 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt
> > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
> > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
...
> > +properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - mediatek,mt2701-smi-common
> > + - mediatek,mt2712-smi-common
> > + - mediatek,mt6779-smi-common
> > + - mediatek,mt8173-smi-common
> > + - mediatek,mt8183-smi-common
> > +
> > + - description: for mt7623
> > + items:
> > + - const: mediatek,mt7623-smi-common
> > + - const: mediatek,mt2701-smi-common
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + description: |
> > + apb and smi are mandatory. the async is only for generation 1 smi HW.
> > + gals(global async local sync) also is optional, here is the list which
> > + require gals: mt6779 and mt8183.
> > + minItems: 2
> > + maxItems: 4
> > + items:
> > + - description: apb is Advanced Peripheral Bus clock, It's the clock for
> > + setting the register.
> > + - description: smi is the clock for transfer data and command.
> > + - description: async is asynchronous clock, it help transform the smi clock
> > + into the emi clock domain.
> > + - description: gals0 is the path0 clock of gals.
> > + - description: gals1 is the path1 clock of gals.
> > +
> > + clock-names:
> > + oneOf:
> > + - items:
> > + - const: apb
> > + - const: smi
> > + - items:
> > + - const: apb
> > + - const: smi
> > + - const: async
> > + - items:
> > + - const: apb
> > + - const: smi
> > + - const: gals0
> > + - const: gals1
>
> Similarly to my comment to other properties, this requirement per
> compatible should be part of the schema within 'if-then'.
I'm not so familiar with this format. Do this has "if-then-'else
if'-then-else"?
I tried below instead of the clocks segment above:
===================================
if:
properties:
compatible:
enum:
- mediatek,mt6779-smi-common
- mediatek,mt8183-smi-common
then:
properties:
clock:
items:
- description: apb is the clock for setting the register..
- description: smi is the clock for transfer data and command.
- description: gals0 is the path0 clock of gals(global async
local sync).
- description: gals1 is the path1 clock of gals.
clock-names:
items:
- const: apb
- const: smi
- const: gals0
- const: gals1
else:
if:
properties:
compatible:
contains:
enum:
- mediatek,mt2701-smi-common
then:
properties:
clocks:
items:
- description: apb is the clock for setting the register.
- description: smi is the clock for transfer data and command.
- description: async is asynchronous clock, it help transform
the smi clock
into the emi clock domain.
clock-names:
items:
- const: apb
- const: smi
- const: async
else:
properties:
clocks:
items:
- description: apb is the clock for setting the register.
- description: smi is the clock for transfer data and
command.
clock-names:
items:
- const: apb
- const: smi
================================
But I got a warning when dt_binding_check:
CHKDT
Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
SCHEMA
Documentation/devicetree/bindings/processed-schema-examples.yaml
DTC
Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml
CHECK
Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml
.../Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml: smi@...22000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
From
schema: .../Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
Any suggestion about this?
Thanks.
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists