[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdXjBSzbs4yAPJ-XUTBRZWKN61hO8vQ1-nGN5nAo7JnV-w@mail.gmail.com>
Date: Tue, 6 Oct 2020 09:37:43 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Rob Herring <robh@...nel.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Andrew Lunn <andrew@...n.ch>,
Ulf Hansson <ulf.hansson@...aro.org>,
USB list <linux-usb@...r.kernel.org>,
Peter Meerwald-Stadler <pmeerw@...erw.net>,
Sam Ravnborg <sam@...nborg.org>,
Linux PWM List <linux-pwm@...r.kernel.org>,
linux-iio@...r.kernel.org, Viresh Kumar <vireshk@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
linux-pci <linux-pci@...r.kernel.org>,
DRI Development <dri-devel@...ts.freedesktop.org>,
Sebastian Reichel <sre@...nel.org>, linux-ide@...r.kernel.org,
Thierry Reding <thierry.reding@...il.com>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Pavel Machek <pavel@....cz>,
Miquel Raynal <miquel.raynal@...tlin.com>,
linux-riscv <linux-riscv@...ts.infradead.org>,
Lee Jones <lee.jones@...aro.org>,
linux-clk <linux-clk@...r.kernel.org>,
linux-leds@...r.kernel.org, Vignesh Raghavendra <vigneshr@...com>,
linux-rtc@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
Marc Zyngier <maz@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Chanwoo Choi <cw00.choi@...sung.com>,
MyungJoo Ham <myungjoo.ham@...sung.com>,
"open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
linux-input@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
Vivien Didelot <vivien.didelot@...il.com>,
Wolfgang Grandegger <wg@...ndegger.com>,
Linux Media Mailing List <linux-media@...r.kernel.org>,
linux-hwmon@...r.kernel.org, Albert Ou <aou@...s.berkeley.edu>,
Jason Cooper <jason@...edaemon.net>,
Linux PM list <linux-pm@...r.kernel.org>,
linux-can@...r.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
Mark Brown <broonie@...nel.org>,
Marc Kleine-Budde <mkl@...gutronix.de>,
Paul Walmsley <paul.walmsley@...ive.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Thomas Gleixner <tglx@...utronix.de>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Jens Axboe <axboe@...nel.dk>,
Alessandro Zummo <a.zummo@...ertech.it>,
Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Stephen Boyd <sboyd@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Linux MMC List <linux-mmc@...r.kernel.org>,
Liam Girdwood <lgirdwood@...il.com>,
linux-spi <linux-spi@...r.kernel.org>,
Linux I2C <linux-i2c@...r.kernel.org>,
Vinod Koul <vkoul@...nel.org>,
Palmer Dabbelt <palmer@...belt.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Richard Weinberger <richard@....at>,
dmaengine <dmaengine@...r.kernel.org>,
MTD Maling List <linux-mtd@...ts.infradead.org>,
"David S. Miller" <davem@...emloft.net>,
Jonathan Cameron <jic23@...nel.org>,
Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'
Hi Rob,
On Mon, Oct 5, 2020 at 8:39 PM Rob Herring <robh@...nel.org> wrote:
> This doesn't yet do anything in the tools, but make it explicit so we can
> check either 'unevaluatedProperties' or 'additionalProperties' is present
> in schemas.
>
> 'unevaluatedProperties' is appropriate when including another schema (via
> '$ref') and all possible properties and/or child nodes are not
> explicitly listed in the schema with the '$ref'.
>
> This is in preparation to add a meta-schema to check for missing
> 'unevaluatedProperties' or 'additionalProperties'. This has been a
> constant source of review issues.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
Thanks for your patch!
> Documentation/devicetree/bindings/bus/renesas,bsc.yaml | 2 ++
> .../bindings/memory-controllers/renesas,rpc-if.yaml | 2 ++
> Documentation/devicetree/bindings/net/renesas,ether.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,hscif.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,sci.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,scif.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,scifa.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,scifb.yaml | 2 ++
> Documentation/devicetree/bindings/spi/renesas,hspi.yaml | 2 ++
> Documentation/devicetree/bindings/spi/renesas,rspi.yaml | 2 ++
> Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 2 ++
Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>
> --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml
> @@ -85,6 +85,8 @@ required:
> - clocks
> - pinctrl-0
>
> +unevaluatedProperties: false
This one has received an "additionalProperties: false" in commit
41506bff84f1563e ("dt-bindings: net: renesas, ether: Improve schema validation")
in net-next, which you probably want to remove.
> +
> examples:
> # Lager board
> - |
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists