linux-kernel - Re: [PATCH 2/2] x86/entry/32: Remove leftover macros after stackprotector cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201006083415.GO2628@hirez.programming.kicks-ass.net>
Date:   Tue, 6 Oct 2020 10:34:15 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     x86@...nel.org, LKML <linux-kernel@...r.kernel.org>,
        "Christopherson, Sean J" <sean.j.christopherson@...el.com>
Subject: Re: [PATCH 2/2] x86/entry/32: Remove leftover macros after
 stackprotector cleanups

On Mon, Oct 05, 2020 at 12:30:04PM -0700, Andy Lutomirski wrote:
>  .macro SAVE_ALL pt_regs_ax=%eax switch_stacks=0 skip_gs=0 unwind_espfix=0
>  	cld
>  .if \skip_gs == 0
> -	PUSH_GS
> +	pushl	$0
>  .endif
>  	pushl	%fs
>  

Is there a good reason not to just push gs into it? It might be nice if
pt_regs is complete.