linux-kernel - Re: [PATCH] locking/seqlock: Tweak DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201006131739.GS2628@hirez.programming.kicks-ass.net>
Date:   Tue, 6 Oct 2020 15:17:39 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Will Deacon <will@...nel.org>
Cc:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc

On Tue, Oct 06, 2020 at 01:41:47PM +0100, Will Deacon wrote:
> On Thu, Sep 24, 2020 at 05:48:51PM +0200, Sebastian Andrzej Siewior wrote:
> > ctags creates a warning:
> > |ctags: Warning: include/linux/seqlock.h:738: null expansion of name pattern "\2"
> > 
> > The DEFINE_SEQLOCK() macro is passed to ctags and being told to expect
> > an argument.
> > 
> > Add a dummy argument to keep ctags quiet.
> > 
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> > ---
> >  include/linux/seqlock.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> > index 962d9768945f0..4a69e74dc7ce9 100644
> > --- a/include/linux/seqlock.h
> > +++ b/include/linux/seqlock.h
> > @@ -735,7 +735,7 @@ typedef struct {
> >  	} while (0)
> >  
> >  /**
> > - * DEFINE_SEQLOCK() - Define a statically allocated seqlock_t
> > + * DEFINE_SEQLOCK(sl) - Define a statically allocated seqlock_t
> >   * @sl: Name of the seqlock_t instance
> >   */
> >  #define DEFINE_SEQLOCK(sl) \
> 
> Acked-by: Will Deacon <will@...nel.org>


Thanks!