linux-kernel - Re: [PATCH 5/6] ftrace: replace do_for_each_ftrace_rec() with for_ftrace_rec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201006104217.005cec7c@gandalf.local.home>
Date:   Tue, 6 Oct 2020 10:42:17 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Wei Yang <richard.weiyang@...ux.alibaba.com>
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] ftrace: replace do_for_each_ftrace_rec() with
 for_ftrace_rec_iter()

On Mon, 31 Aug 2020 11:11:03 +0800
Wei Yang <richard.weiyang@...ux.alibaba.com> wrote:

> Now we have two similar infrastructure to iterate ftrace_page and
> dyn_ftrace:
> 
>   * do_for_each_ftrace_rec()
>   * for_ftrace_rec_iter()
> 
> The 2nd one, for_ftrace_rec_iter(), looks more generic, so preserve it
> and replace do_for_each_ftrace_rec() with it.
> 

I also didn't pull in this patch. The reason is that the
for_ftrace_rec_iter() is specific for external usage (for archs to use) and
requires two function calls to do the iterations.

The do_for_each_ftrace_rec() is a faster, light weight version, but for
internal use only.

I rather keep both, as each has their own, but slightly different, use
cases.

-- Steve