linux-kernel - RE: [PATCH] media: ov2740: select regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB3995D488E86C6AD842AF090E990D0@DM6PR11MB3995.namprd11.prod.outlook.com>
Date:   Tue, 6 Oct 2020 03:22:35 +0000
From:   "Cao, Bingbu" <bingbu.cao@...el.com>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
CC:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] media: ov2740: select regmap

Sergey, thanks for your patch.

Reviewed-by: Bingbu Cao <bingbu.cao@...el.com>

________________________
BRs,  
Bingbu Cao                          


> -----Original Message-----
> From: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Sent: Wednesday, September 30, 2020 9:13 AM
> To: Mauro Carvalho Chehab <mchehab@...nel.org>; Cao, Bingbu
> <bingbu.cao@...el.com>
> Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>; linux-media@...r.kernel.org;
> linux-kernel@...r.kernel.org; Sergey Senozhatsky
> <sergey.senozhatsky@...il.com>
> Subject: [PATCH] media: ov2740: select regmap
> 
> Fix OV2740 build breakage by selecting REGMAP_I2C config:
> 
> ov2740.c:1011:23: error: variable has incomplete type 'struct regmap_config'
>         struct regmap_config regmap_config = { };
>                              ^
> ov2740.c:1011:9: note: forward declaration of 'struct regmap_config'
>         struct regmap_config regmap_config = { };
>                ^
> ov2740.c:1028:11: error: implicit declaration of function
> 'devm_regmap_init_i2c'
>         regmap = devm_regmap_init_i2c(client, &regmap_config);
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> ---
>  drivers/media/i2c/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index
> 878f66ef2719..c64326ca331c 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -877,6 +877,7 @@ config VIDEO_OV2740
>  	select MEDIA_CONTROLLER
>  	select VIDEO_V4L2_SUBDEV_API
>  	select V4L2_FWNODE
> +	select REGMAP_I2C
>  	help
>  	  This is a Video4Linux2 sensor driver for the OmniVision
>  	  OV2740 camera.
> --
> 2.28.0