linux-kernel - Re: [PATCH 2/9] mm, page_alloc: calculate pageset high and batch once per zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <325c9545-a307-5bbe-261c-43aaeda34322@suse.cz>
Date:   Wed, 7 Oct 2020 00:04:02 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Michal Hocko <mhocko@...e.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        David Hildenbrand <david@...hat.com>,
        Oscar Salvador <osalvador@...e.de>,
        Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH 2/9] mm, page_alloc: calculate pageset high and batch once
 per zone

On 10/5/20 2:52 PM, Michal Hocko wrote:
> On Tue 22-09-20 16:37:05, Vlastimil Babka wrote:
>> We currently call pageset_set_high_and_batch() for each possible cpu, which
>> repeats the same calculations of high and batch values.
>> 
>> Instead call the function just once per zone, and make it apply the calculated
>> values to all per-cpu pagesets of the zone.
>> 
>> This also allows removing the zone_pageset_init() and __zone_pcp_update()
>> wrappers.
>> 
>> No functional change.
>> 
>> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
>> Reviewed-by: Oscar Salvador <osalvador@...e.de>
>> Reviewed-by: David Hildenbrand <david@...hat.com>
> 
> I like this. One question below
> Acked-by: Michal Hocko <mhocko@...e.com>

Thanks.

> I hope I am not misreading the diff but it seems that setup_zone_pageset
> is calling pageset_init which is then done again by
> zone_set_pageset_high_and_batch as a part of pageset_update

No, pageset_init() is not called again from there, so must be insufficient diff 
context giving that impression.