linux-kernel - Re: [PATCH] scsi: pmcraid: Fix memory allocation in 'pmcraid_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1r1qa68lk.fsf@ca-mkp.ca.oracle.com>
Date:   Tue, 06 Oct 2020 23:04:41 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     bvanassche@....org
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        jejb@...ux.ibm.com, martin.petersen@...cle.com, jthumshirn@...e.de,
        hare@...e.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: pmcraid: Fix memory allocation in
 'pmcraid_alloc_sglist()'


> When the scatter list is allocated in 'pmcraid_alloc_sglist()', the
> corresponding pointer should be stored in 'scatterlist' within the
> 'pmcraid_sglist' structure. Otherwise, 'scatterlist' is NULL.
>
> This leads to a potential memory leak and NULL pointer dereference.

> Fixes: ed4414cef2ad ("scsi: pmcraid: Use sgl_alloc_order() and sgl_free_order()")

This does indeed look odd. Bart?

-- 
Martin K. Petersen	Oracle Linux Engineering