linux-kernel - Re: [PATCH 1/3] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Oct 2020 17:46:33 -0400
From:   Vivek Unune <npcomplete13@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     devicetree@...r.kernel.org, Hauke Mehrtens <hauke@...ke-m.de>,
        Rafał Miłecki <zajec5@...il.com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: BCM5301X: Linksys EA9500 make use of
 pinctrl

On Wed, Oct 07, 2020 at 11:01:34PM +0200, Andrew Lunn wrote:
> On Wed, Oct 07, 2020 at 03:01:50PM -0400, Vivek Unune wrote:
> > Forgo the use of mmioreg mdio mux infavor of the pinctrl
> 
> Hi Vivek
> 
> Could you add some more details please. I don't know this
> hardware. I'm assuming there are two MDIO busses, external as talked
> about in the comments, and an internal one? And for this hardware you
> only need one of them? But i don't see what pinmux has to do with
> this?
Hi Andrew,

There are indeed two mdio busses. To access the external bus, 9th bit
of the mdio register has to be set. And to enable mii function,
one has to set the registers 6 & 7 which is part of the pin controller.
Earlier the pin controller was not defined and I resorted to use a
combination of memory mapped io mux to change desired bits.

Now that we have a pin controller - which is resposnsible for other 
functionality such as pwm, i2c, uart2, it makes sense to have a consistent
device tree

Hope this helps,

Vivek


> 
> Thanks
> 	Andrew
>