linux-kernel - Re: [PATCH] scsi: be2iscsi: Fix a theoretical leak in beiscsi_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <160204240578.16940.13402401013800356061.b4-ty@oracle.com>
Date:   Tue,  6 Oct 2020 23:47:48 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Subbu Seetharaman <subbu.seetharaman@...adcom.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Jitendra Bhivare <jitendra.bhivare@...adcom.com>,
        kernel-janitors@...r.kernel.org,
        Jayamohan Kallickal 
        <jayamohank@...edirect-LB5-1afb6e2973825a56.elb.us-east-1.amazonaws.com>,
        Ketan Mukadam <ketan.mukadam@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-kernel@...r.kernel.org,
        James Bottomley <James.Bottomley@...e.de>,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()

On Mon, 28 Sep 2020 12:13:00 +0300, Dan Carpenter wrote:

> The be_fill_queue() function can only fail when "eq_vaddress" is NULL
> and since it's non-NULL here that means the function call can't fail.
> But imagine if it could, then in that situation we would want to store
> the "paddr" so that dma memory can be released.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()
      https://git.kernel.org/mkp/scsi/c/38b2db564d9a

-- 
Martin K. Petersen	Oracle Linux Engineering