linux-kernel - Re: [PATCH bpf-next] kernel/bpf/verifier: fix build when NET is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcf3f659-027e-517f-086d-deb3ad33d953@fb.com>
Date:   Tue, 6 Oct 2020 23:12:05 -0700
From:   Yonghong Song <yhs@...com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        <linux-kernel@...r.kernel.org>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>, <linux-next@...r.kernel.org>
Subject: Re: [PATCH bpf-next] kernel/bpf/verifier: fix build when NET is not
 enabled



On 10/6/20 7:16 PM, Randy Dunlap wrote:
> Fix build errors in kernel/bpf/verifier.c when CONFIG_NET is
> not enabled.
> 
> ../kernel/bpf/verifier.c:3995:13: error: ‘btf_sock_ids’ undeclared here (not in a function); did you mean ‘bpf_sock_ops’?
>    .btf_id = &btf_sock_ids[BTF_SOCK_TYPE_SOCK_COMMON],
> 
> ../kernel/bpf/verifier.c:3995:26: error: ‘BTF_SOCK_TYPE_SOCK_COMMON’ undeclared here (not in a function); did you mean ‘PTR_TO_SOCK_COMMON’?
>    .btf_id = &btf_sock_ids[BTF_SOCK_TYPE_SOCK_COMMON],
> 
> Fixes: 1df8f55a37bd ("bpf: Enable bpf_skc_to_* sock casting helper to networking prog type")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: netdev@...r.kernel.org
> Cc: bpf@...r.kernel.org
> Cc: Martin KaFai Lau <kafai@...com>
> Cc: linux-next@...r.kernel.org

Acked-by: Yonghong Song <yhs@...com>