linux-kernel - Re: [RFC][PATCH 03/12] mm/vmscan: replace implicit RECLAIM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2010070845550.113351@www.lameter.com>
Date:   Wed, 7 Oct 2020 08:47:11 +0000 (UTC)
From:   Christopher Lameter <cl@...ux.com>
To:     Dave Hansen <dave.hansen@...ux.intel.com>
cc:     linux-kernel@...r.kernel.org, ben.widawsky@...el.com,
        alex.shi@...ux.alibaba.com, tobin@...nel.org,
        akpm@...ux-foundation.org, ying.huang@...el.com,
        dan.j.williams@...el.com, cai@....pw, dwagner@...e.de
Subject: Re: [RFC][PATCH 03/12] mm/vmscan: replace implicit RECLAIM_ZONE
 checks with explicit checks

On Tue, 6 Oct 2020, Dave Hansen wrote:

> These zero checks are not great because it is not obvious what a zero
> mode *means* in the code.  Replace them with a helper which makes it
> more obvious: node_reclaim_enabled().

Well it uselessly checks bits. But whatever. It will prevent future code
removal.

Acked-by: Christoph Lameter <cl@...ux.com>