linux-kernel - Re: [PATCH v7 0/5] Add shared workqueue support for idxd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201007084856.GE5607@zn.tnic>
Date:   Wed, 7 Oct 2020 10:48:56 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Dave Jiang <dave.jiang@...el.com>, dan.j.williams@...el.com,
        tony.luck@...el.com, ashok.raj@...el.com, kevin.tian@...el.com,
        fenghua.yu@...el.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 0/5] Add shared workqueue support for idxd driver

On Wed, Oct 07, 2020 at 12:31:32PM +0530, Vinod Koul wrote:
> Applied, thanks

I'm tired of repeating what you should've done - your branch doesn't
even build. How did you test it?

Also, what happens if Linus merges your branch first, before tip?

Oh boy.

In file included from ./arch/x86/include/asm/tsc.h:9,
                 from ./arch/x86/include/asm/timex.h:6,
                 from ./include/linux/timex.h:65,
                 from ./include/linux/time32.h:13,
                 from ./include/linux/time.h:73,
                 from ./include/linux/stat.h:19,
                 from ./include/linux/module.h:13,
                 from drivers/dma/idxd/init.c:5:
drivers/dma/idxd/init.c: In function ‘idxd_init_module’:
drivers/dma/idxd/init.c:526:20: error: ‘X86_FEATURE_ENQCMD’ undeclared (first use in this function); did you mean ‘X86_FEATURE_PCID’?
  526 |  if (!boot_cpu_has(X86_FEATURE_ENQCMD))
      |                    ^~~~~~~~~~~~~~~~~~
./arch/x86/include/asm/cpufeature.h:118:24: note: in definition of macro ‘cpu_has’
  118 |  (__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
      |                        ^~~
drivers/dma/idxd/init.c:526:7: note: in expansion of macro ‘boot_cpu_has’
  526 |  if (!boot_cpu_has(X86_FEATURE_ENQCMD))
      |       ^~~~~~~~~~~~
drivers/dma/idxd/init.c:526:20: note: each undeclared identifier is reported only once for each function it appears in
  526 |  if (!boot_cpu_has(X86_FEATURE_ENQCMD))
      |                    ^~~~~~~~~~~~~~~~~~
./arch/x86/include/asm/cpufeature.h:118:24: note: in definition of macro ‘cpu_has’
  118 |  (__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
      |                        ^~~
drivers/dma/idxd/init.c:526:7: note: in expansion of macro ‘boot_cpu_has’
  526 |  if (!boot_cpu_has(X86_FEATURE_ENQCMD))
      |       ^~~~~~~~~~~~
make[3]: *** [scripts/Makefile.build:283: drivers/dma/idxd/init.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:500: drivers/dma/idxd] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [scripts/Makefile.build:500: drivers/dma] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1788: drivers] Error 2
make: *** Waiting for unfinished jobs....

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette