linux-kernel - Re: [PATCH] gpio: pca953x: Survive spurious interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdb3y_r_+Mq8K=Jog21wiFH54F18ED8eBwT4rM_zxcCUA@mail.gmail.com>
Date:   Wed, 7 Oct 2020 15:02:14 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Marc Zyngier <maz@...nel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        kernel-team@...roid.com
Subject: Re: [PATCH] gpio: pca953x: Survive spurious interrupts

On Wed, Oct 7, 2020 at 12:49 PM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Mon, Oct 5, 2020 at 4:02 PM Marc Zyngier <maz@...nel.org> wrote:
>
> > The pca953x driver never checks the result of irq_find_mapping(),
> > which returns 0 when no mapping is found. When a spurious interrupt
> > is delivered (which can happen under obscure circumstances), the
> > kernel explodes as it still tries to handle the error code as
> > a real interrupt.
> >
> > Handle this particular case and warn on spurious interrupts.
> >
> > Signed-off-by: Marc Zyngier <maz@...nel.org>

Wait, doesn't actually [1]  fix the reported issue?
Marc, can you confirm this?

[1]: e43c26e12dd4 ("gpio: pca953x: Fix uninitialized pending variable")


-- 
With Best Regards,
Andy Shevchenko