linux-kernel - Re: [PATCH 2/2] dt-bindings: pinctrl: qcom: add msm8953 pinctrl bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201007120815.GA882584@trashcan>
Date:   Wed, 7 Oct 2020 15:08:15 +0300
From:   Vladirmir Lisak <junak.pub@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: qcom: add msm8953 pinctrl
 bindings

Hi! Thank you for your reply! 

On Tue, Oct 06, 2020 at 04:22:34PM -0500, Rob Herring wrote:
> 
> For new bindings, please define a node name pattern you can match on 
> and avoid this if/then. '-pins$' is my preference.
> 

Ok, i will change it.

> > +              #interrupt-cells = <2>;
> > +              gpio-controller;
> > +              #gpio-cells = <2>;
> > +              gpio-ranges = <&tlmm 0 0 142>;
> 
> Please show at least 1 child node.
> 

I will add it in next version.