linux-kernel - Re: [PATCH] qla2xxx: Use constant when it is known.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <39CE3456-73A7-4533-BE7F-382469695E08@oracle.com>
Date:   Wed, 7 Oct 2020 08:29:24 -0500
From:   Himanshu Madhani <himanshu.madhani@...cle.com>
To:     Pavel Machek <pavel@...x.de>
Cc:     Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qla2xxx: Use constant when it is known.



> On Sep 21, 2020, at 6:23 AM, Pavel Machek <pavel@...x.de> wrote:
> 
> Directly return constant when it is known, to make code easier to
> understand.
> 
> Signed-off-by: Pavel Machek (CIP) <pavel@...x.de>
> 
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index 90bbc61f361b..248197e9e8ea 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -530,7 +530,7 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
> 	fc_port_t *fcport;
> 	struct srb_iocb *nvme;
> 	struct scsi_qla_host *vha;
> -	int rval = -ENODEV;
> +	int rval;
> 	srb_t *sp;
> 	struct qla_qpair *qpair = hw_queue_handle;
> 	struct nvme_private *priv = fd->private;
> @@ -538,14 +538,14 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
> 
> 	if (!priv) {
> 		/* nvme association has been torn down */
> -		return rval;
> +		return -ENODEV;
> 	}
> 
> 	fcport = qla_rport->fcport;
> 
> 	if (!qpair || !fcport || (qpair && !qpair->fw_started) ||
> 	    (fcport && fcport->deleted))
> -		return rval;
> +		return -ENODEV;
> 
> 	vha = fcport->vha;
> 	/*
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>

--
Himanshu Madhani	 Oracle Linux Engineering