linux-kernel - Re: [PATCH 05/12] samples: configfs: improve alignment of broken lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201007134447.GB764@lst.de>
Date:   Wed, 7 Oct 2020 15:44:47 +0200
From:   Christoph Hellwig <hch@....de>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Joel Becker <jlbec@...lplan.org>, Christoph Hellwig <hch@....de>,
        linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH 05/12] samples: configfs: improve alignment of broken
 lines

On Thu, Sep 24, 2020 at 02:45:19PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> Improve the coding style by correctly aligning broken lines where
> possible.

NAK, this actually makes the code much worse.  Two-tab indents are
technically superior as they avoid pointlessly long line, and avoid
continuous re-indenting when prototypes change even just slightly.