linux-kernel - Re: [PATCH] PM: runtime: Use pmruntime sync variant to put suppliers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hxdxV6pB5q94qCEmeDXOMJQzL3b8ZokgTn00i0MbykvQ@mail.gmail.com>
Date:   Wed, 7 Oct 2020 16:37:50 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Stanimir Varbanov <stanimir.varbanov@...aro.org>
Cc:     Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH] PM: runtime: Use pmruntime sync variant to put suppliers

On Wed, Oct 7, 2020 at 2:20 AM Stanimir Varbanov
<stanimir.varbanov@...aro.org> wrote:
>
> Calling pm_runtime_put_sync over a device with suppliers with device
> link flags PM_RUNTIME | RPM_ACTIVE it is observed that the supplier
> is not put (turned off) at the end, but instead put asynchronously.

Yes, that's by design.

> In some case This could lead to issues for the callers which expects
> that the pmruntime sync variants should also put the suppliers
> synchronously.

Why would anyone expect that to happen?

> Also the opposite rpm_get_suppliers is already using pmruntime _sync
> variant of the API.

Yes, it does, because that is necessary.

> Correct this by changing pmruntime_put to pmruntime_put_sync in
> rpm_put_suppliers.

It is not a correction, but a change in behavior without good enough
rationale, as it stands.

Thanks!