linux-kernel - Re: [PATCH net-next v2 04/16] devlink: Add reload stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201007154618.GB3064@nanopsycho>
Date:   Wed, 7 Oct 2020 17:46:18 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Moshe Shemesh <moshe@...lanox.com>, f@...opsycho
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...dia.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 04/16] devlink: Add reload stats

Wed, Oct 07, 2020 at 08:00:45AM CEST, moshe@...lanox.com wrote:
>Add reload stats to hold the history per reload action type and limit.
>
>For example, the number of times fw_activate has been performed on this
>device since the driver module was added or if the firmware activation
>was performed with or without reset.
>
>Add devlink notification on stats update.
>
>Expose devlink reload stats to the user through devlink dev get command.
>
>Examples:
>$ devlink dev show
>pci/0000:82:00.0:
>  stats:
>      reload:
>        driver_reinit 2 fw_activate 1 fw_activate_no_reset 0
>pci/0000:82:00.1:
>  stats:
>      reload:
>        driver_reinit 1 fw_activate 0 fw_activate_no_reset 0
>
>$ devlink dev show -jp
>{
>    "dev": {
>        "pci/0000:82:00.0": {
>            "stats": {
>                "reload": {
>                    "driver_reinit": 2,
>                    "fw_activate": 1,
>                    "fw_activate_no_reset": 0
>                }
>            }
>        },
>        "pci/0000:82:00.1": {
>            "stats": {
>                "reload": {
>                    "driver_reinit": 1,
>                    "fw_activate": 0,
>                    "fw_activate_no_reset": 0
>                }
>            }
>        }
>    }
>}
>
>Signed-off-by: Moshe Shemesh <moshe@...lanox.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>