linux-kernel - Re: [PATCH 2/4] platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Oct 2020 11:47:02 -0400
From:   Rajneesh Bhardwaj <irenic.rajneesh@...il.com>
To:     "David E. Box" <david.e.box@...ux.intel.com>
Cc:     david.e.box@...el.com, dvhart@...radead.org, andy@...radead.org,
        gayatri.kammela@...el.com, linux-kernel@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@...el.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        Rui Zhang <rui.zhang@...el.com>
Subject: Re: [PATCH 2/4] platform/x86: intel_pmc_core: Add Intel RocketLake
 (RKL) support

On Tue, Oct 6, 2020 at 11:51 PM David E. Box
<david.e.box@...ux.intel.com> wrote:
>
> From: Gayatri Kammela <gayatri.kammela@...el.com>
>
> Add RocketLake to the list of the platforms that intel_pmc_core driver
> supports for pmc_core device. RocketLake reuses all the TigerLake PCH IPs.

Just a nit here - I guess the convention was to leave a space in IP
names such as "Tiger Lake", "Rocket Lake" like it's done in previous
patches too. I am not sure whether it's a new convention but it's good
to be consistent throughout the series.

Other than that, the series is:
Reviewed-by: Rajneesh Bhardwaj <irenic.rajneesh@...il.com>

>
>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...el.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: David E. Box <david.e.box@...el.com>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Rui Zhang <rui.zhang@...el.com>
> Signed-off-by: Gayatri Kammela <gayatri.kammela@...el.com>
> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> ---
>  drivers/platform/x86/intel_pmc_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index d959fa698ec5..f0347ee8a4d6 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -1155,6 +1155,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {
>         X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE,           &tgl_reg_map),
>         X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT,        &tgl_reg_map),
>         X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L,      &icl_reg_map),
> +       X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE,          &tgl_reg_map),
>         {}
>  };
>
> --
> 2.20.1
>


-- 
Thanks,
Rajneesh