[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAAOTY__X8L2sK0s3rkq2LDaMNoQrZKfzn=aJ791fK=UwnJMAyQ@mail.gmail.com>
Date: Thu, 8 Oct 2020 08:01:12 +0800
From: Chun-Kuang Hu <chunkuang.hu@...nel.org>
To: Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc: linux-kernel <linux-kernel@...r.kernel.org>,
Collabora Kernel ML <kernel@...labora.com>,
Yongqiang Niu <yongqiang.niu@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Nicolas Boichat <drinkcat@...omium.org>,
Hsin-Yi Wang <hsinyi@...omium.org>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>,
CK Hu <ck.hu@...iatek.com>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the
routing registers
Hi, Enric:
Enric Balletbo i Serra <enric.balletbo@...labora.com> 於 2020年10月7日 週三 上午3:33寫道:
>
> From: CK Hu <ck.hu@...iatek.com>
>
> Actually, setting the registers for routing, use multiple 'if-else' for different
> routes, but this code would be more and more complicated while we
> support more and more SoCs. Change that and use a table per SoC so the
> code will be more portable and clear.
>
> Signed-off-by: CK Hu <ck.hu@...iatek.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
>
> drivers/soc/mediatek/mtk-mmsys.c | 393 +++++++++++++++++--------------
> 1 file changed, 210 insertions(+), 183 deletions(-)
>
[snip]
>
> static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
> @@ -93,10 +115,6 @@ static const struct mtk_mmsys_driver_data mt6797_mmsys_driver_data = {
> .clk_driver = "clk-mt6797-mm",
> };
>
> -static const struct mtk_mmsys_driver_data mt8173_mmsys_driver_data = {
> - .clk_driver = "clk-mt8173-mm",
> -};
> -
> static const struct mtk_mmsys_driver_data mt8183_mmsys_driver_data = {
> .clk_driver = "clk-mt8183-mm",
> };
> @@ -106,180 +124,192 @@ struct mtk_mmsys {
> const struct mtk_mmsys_driver_data *data;
> };
>
[snip]
> +static const struct mtk_mmsys_driver_data mt8173_mmsys_driver_data = {
> + .clk_driver = "clk-mt8173-mm",
> + .routes = mt8173_mmsys_routing_table,
> + .num_routes = ARRAY_SIZE(mt8173_mmsys_routing_table),
> +};
>
I remove my Reviewed-by tag. You does not set routes for mt2701 and
mt2712, but these two SoC need that. Maybe now they use the same table
as mt8173.
Regards,
Chun-Kuang.
Powered by blists - more mailing lists