linux-kernel - Re: [PATCH] power: supply: max17040: Fix ptr to enum cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201008230749.pawqtio7jzvsn2hr@earth.universe>
Date:   Fri, 9 Oct 2020 01:07:49 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Iskren Chernev <iskren.chernev@...il.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] power: supply: max17040: Fix ptr to enum cast

Hi,

On Mon, Oct 05, 2020 at 11:00:38PM +0300, Iskren Chernev wrote:
> clang complains about casting pointers to smaller enum types.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Iskren Chernev <iskren.chernev@...il.com>
> ---

Thanks, queued.

> P.S. I fixed a similar issue in v5, but it was in another patch, and the
> test robot only complains about the first issue, so I missed this one.
> 
> There is a similar warning in ltc2941-battery-gauge, let me know if I
> should submit a fix for it as well.

Sure.

-- Sebastian

>  drivers/power/supply/max17040_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c
> index 1d7510a59295d..d956c67d51558 100644
> --- a/drivers/power/supply/max17040_battery.c
> +++ b/drivers/power/supply/max17040_battery.c
> @@ -247,7 +247,7 @@ static int max17040_get_of_data(struct max17040_chip *chip)
>  {
>  	struct device *dev = &chip->client->dev;
>  	struct chip_data *data = &max17040_family[
> -		(enum chip_id) of_device_get_match_data(dev)];
> +		(uintptr_t) of_device_get_match_data(dev)];
>  	int rcomp_len;
>  	u8 rcomp[2];
> 
> 
> base-commit: f9d293364b452b651292ed3034dd06c57b1754d5
> --
> 2.28.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)