linux-kernel - Re: [PATCH] misc: Kconfig: fix a HISI_HIKEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201008062737.GA309212@ubuntu-m3-large-x86>
Date:   Wed, 7 Oct 2020 23:27:37 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linuxarm@...wei.com, mauro.chehab@...wei.com,
        John Stultz <john.stultz@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: Kconfig: fix a HISI_HIKEY_USB dependency

On Thu, Oct 08, 2020 at 08:24:53AM +0200, Mauro Carvalho Chehab wrote:
> The dependency should be just USB_ROLE_SWITCH, instead
> of CONFIG_USB_ROLE_SWITCH.
> 
> Fixes: 2827d98bc5d6 ("misc: Kconfig: add a new dependency for HISI_HIKEY_USB")
> 
> Reported-by: Nathan Chancellor <natechancellor@...il.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

Reviewed-by: Nathan Chancellor <natechancellor@...il.com>

> ---
>  drivers/misc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 7cee2b72c09e..d5ce8082b0a0 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -459,7 +459,7 @@ config PVPANIC
>  config HISI_HIKEY_USB
>  	tristate "USB GPIO Hub on HiSilicon Hikey 960/970 Platform"
>  	depends on (OF && GPIOLIB) || COMPILE_TEST
> -	depends on CONFIG_USB_ROLE_SWITCH
> +	depends on USB_ROLE_SWITCH
>  	help
>  	  If you say yes here this adds support for the on-board USB GPIO hub
>  	  found on HiKey 960/970 boards, which is necessary to support
> -- 
> 2.26.2
>