linux-kernel - Re: [PATCH v2 04/11] drivers/base/devcoredump: convert devcd_count to counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202010080036.A3BEFB0BE@keescook>
Date:   Thu, 8 Oct 2020 00:37:02 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     Shuah Khan <skhan@...uxfoundation.org>, gregkh@...uxfoundation.org,
        rafael@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 04/11] drivers/base/devcoredump: convert devcd_count
 to counter_atomic32

On Thu, Oct 08, 2020 at 08:42:22AM +0200, Johannes Berg wrote:
>  1) each value that we derive from this ever-incrementing (modulo 2^32)
>     variable only get used for a limited amount of time (max. 5 minutes)

Ah! That's what I misunderstood, the resulting value is only used for 5
minutes. Got it; thanks!

> IOW, I disagree with you, and think that counter_atomic_32 is more
> appropriate here than refcount_t.

I agree now! :)

-- 
Kees Cook