lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Oct 2020 11:30:42 +0200 From: Borislav Petkov <bp@...en8.de> To: Arvind Sankar <nivedita@...m.mit.edu> Cc: x86@...nel.org, Joerg Roedel <jroedel@...e.de>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/5] x86/boot: Move get_cmd_line_ptr() and COMMAND_LINE_SIZE into misc.h On Wed, Oct 07, 2020 at 03:53:48PM -0400, Arvind Sankar wrote: > Move get_cmd_line_ptr() and COMMAND_LINE_SIZE into misc.h for easier > use from multiple files. Well, I don't like that. cmdline.c *is* for cmdline-related things. misc.h is a dumping ground for everything but the kitchen sink. Why can't you leave it there and make it visible to other compilation units? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists