lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 08 Oct 2020 11:58:51 +0200 From: Nicolas Saenz Julienne <nsaenzjulienne@...e.de> To: Jim Quinlan <james.quinlan@...adcom.com>, Dan Carpenter <dan.carpenter@...cle.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, bcm-kernel-feedback-list@...adcom.com Cc: Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Florian Fainelli <f.fainelli@...il.com>, Jim Quinlan <jquinlan@...adcom.com>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@...ts.infradead.org>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" <linux-pci@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v1] PCI: brcmstb: fix error return paths in probe() On Thu, 2020-10-01 at 11:18 -0400, Jim Quinlan wrote: > Fixes two cases where we were returning without calling > clk_disable_unprepare(). Although there is a common place to go on probe() > errors (the 'fail' label), one can only jump there after executing > brcm_pcie_setup(), so we have to add clk_disable_unprepare() calls to the > two error paths. > > Fixes: b98f52bc6495 ("PCI: brcmstb: Add control of rescal reset") > Reported-by: kernel test robot <lkp@...el.com> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com> > Signed-off-by: Jim Quinlan <james.quinlan@...adcom.com> > --- Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de> Thanks!
Powered by blists - more mailing lists