[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20201008104643.DF562C433A1@smtp.codeaurora.org>
Date: Thu, 8 Oct 2020 10:46:43 +0000 (UTC)
From: Kalle Valo <kvalo@...eaurora.org>
To: trix@...hat.com
Cc: amitkarwar@...il.com, ganapathi.bhat@....com,
huxinming820@...il.com, davem@...emloft.net, kuba@...nel.org,
natechancellor@...il.com, ndesaulniers@...gle.com,
linville@...driver.com, nishants@...vell.com, rramesh@...vell.com,
bzhao@...vell.com, frankh@...vell.com,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com,
Tom Rix <trix@...hat.com>
Subject: Re: mwifiex: fix double free
trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
>
> clang static analysis reports this problem:
>
> sdio.c:2403:3: warning: Attempt to free released memory
> kfree(card->mpa_rx.buf);
> ^~~~~~~~~~~~~~~~~~~~~~~
>
> When mwifiex_init_sdio() fails in its first call to
> mwifiex_alloc_sdio_mpa_buffer, it falls back to calling it
> again. If the second alloc of mpa_tx.buf fails, the error
> handler will try to free the old, previously freed mpa_rx.buf.
> Reviewing the code, it looks like a second double free would
> happen with mwifiex_cleanup_sdio().
>
> So set both pointers to NULL when they are freed.
>
> Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
> Signed-off-by: Tom Rix <trix@...hat.com>
> Reviewed-by: Brian Norris <briannorris@...omium.org>
Patch applied to wireless-drivers-next.git, thanks.
53708f4fd9cf mwifiex: fix double free
--
https://patchwork.kernel.org/patch/11815655/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists