linux-kernel - Re: [PATCH v2 3/7] mm, page_alloc: remove setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201008130318.GE4967@dhcp22.suse.cz>
Date:   Thu, 8 Oct 2020 15:03:18 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        David Hildenbrand <david@...hat.com>,
        Oscar Salvador <osalvador@...e.de>,
        Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH v2 3/7] mm, page_alloc: remove setup_pageset()

On Thu 08-10-20 14:56:13, Vlastimil Babka wrote:
> On 10/8/20 2:23 PM, Michal Hocko wrote:
> > On Thu 08-10-20 13:41:57, Vlastimil Babka wrote:
> > > We initialize boot-time pagesets with setup_pageset(), which sets high and
> > > batch values that effectively disable pcplists.
> > > 
> > > We can remove this wrapper if we just set these values for all pagesets in
> > > pageset_init(). Non-boot pagesets then subsequently update them to the proper
> > > values.
> > > 
> > > No functional change.
> > > 
> > > Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
> > > Reviewed-by: David Hildenbrand <david@...hat.com>
> > 
> > Acked-by: Michal Hocko <mhocko@...e.com>
> 
> Thanks!
> 
> > Btw. where do we initialize pcp->count? I thought that pcp allocator
> > zeroes out the allocated memory but alloc_percpu is GFP_KERNEL like.
> 
> pageset_init() does:
> memset(p, 0, sizeof(*p))

Ohh, I have missed pcp is embeded into per_cpu_pageset. Using it as s
pointer here confused me. Sorry about the noise.

-- 
Michal Hocko
SUSE Labs