linux-kernel - Re: [PATCH] kprobes: Correct a type error in function kprobes_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Oct 2020 11:08:44 +0800
From:   Zhouyi Zhou <zhouzhouyi@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     naveen.n.rao@...ux.ibm.com, anil.s.keshavamurthy@...el.com,
        David Miller <davem@...emloft.net>, mhiramat@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kprobes: Correct a type error in function kprobes_module_callback

Thanks for the tip!

On Thu, Oct 8, 2020 at 11:06 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Hi,
>
> On 10/7/20 7:59 PM, Zhouyi Zhou wrote:
> > There is a tiny type error in comment of function kprobes_module_callback.
>
> Preferable
>                   typo
> and same in $Subject.
>
> 'type' usually means data type or maybe typedef, or even
> font or typeface.
>
> I suppose you could say a "typing" error (as in using a typewriter
> or keyboard).
>
> >
> > Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>
> > ---
> >  kernel/kprobes.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> > index e995541..9d2042b 100644
> > --- a/kernel/kprobes.c
> > +++ b/kernel/kprobes.c
> > @@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
> >                            within_module_core((unsigned long)p->addr, mod))) {
> >                               /*
> >                                * The vaddr this probe is installed will soon
> > -                              * be vfreed buy not synced to disk. Hence,
> > +                              * be vfreed but not synced to disk. Hence,
> >                                * disarming the breakpoint isn't needed.
> >                                *
> >                                * Note, this will also move any optimized probes
> >
>
> thanks.
> --
> ~Randy
>