linux-kernel - Re: [PATCH v3 2/5] platform/surface: Move Surface 3 WMI driver to platform/surface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79cf1a3a-93e1-5f34-27ae-9fea31a99df7@gmail.com>
Date:   Thu, 8 Oct 2020 17:21:03 +0200
From:   Maximilian Luz <luzmaximilian@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Gayatri Kammela <gayatri.kammela@...el.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Blaž Hrastnik <blaz@...n.io>,
        Stephen Just <stephenjust@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Chen Yu <yu.c.chen@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/5] platform/surface: Move Surface 3 WMI driver to
 platform/surface

On 10/8/20 4:54 PM, Andy Shevchenko wrote:
> On Thu, Oct 8, 2020 at 5:35 PM Maximilian Luz <luzmaximilian@...il.com> wrote:
>>
>> Move the Surface 3 WMI driver from platform/x86 to the newly created
>> platform/surface directory.
> 
>> -# place Microsoft Surface platform drivers here
> 
>> -# place Microsoft Surface platform drivers here
> 
> Not sure if we need these comments in the first place.

I thought it might look a bit weird having the "if" directly followed by
"endif" without at least a comment in between. I'll remove them if you
prefer that.

Thanks,
Max