linux-kernel - Re: [PATCH] scsi: sym53c8xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1a6wxwgva.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 07 Oct 2020 23:12:32 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Matthew Wilcox <willy@...radead.org>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: sym53c8xx_2: fix sizeof mismatch


Colin,

> An incorrect sizeof is being used, struct sym_ccb ** is not correct,
> it should be struct sym_ccb *. Note that since ** is the same size as
> * this is not causing any issues.  Improve this fix by using the idiom
> sizeof(*np->ccbh) as this allows one to not even reference the type of
> the pointer.

Applied to 5.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering