linux-kernel - Re: [PATCH 1/5] firmware: arm_scmi: always initialize protocols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201008191727.ht26r5dnh3iwqj5n@bogus>
Date:   Thu, 8 Oct 2020 20:17:27 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Etienne Carriere <etienne.carriere@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Cristian Marussi <cristian.marussi@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Souvik Chakravarty <Souvik.Chakravarty@....com>
Subject: Re: [PATCH 1/5] firmware: arm_scmi: always initialize protocols

On Thu, Oct 08, 2020 at 04:37:18PM +0200, Etienne Carriere wrote:
> Remove the IDR replacement that prevent initializing an SCMI protocol
> when it has already been initialized. This is needed when there are
> several SCMI agents that do implement a given SCMI protocol unless
> what only the related SCMI protocol communication is initialized only
> for first probed agent.
> 

Can you please elaborate on your usecase please. What do you mean by several
SCMI agents here. OSPM is the only agent we are interested here. What
other agents is this driver supposed to handle here. We allocate memory
in init and calling init multiple times messes up the allocated and
initialised structures.

So NACK for this patch as it needs more work if we need this at all.

-- 
Regards,
Sudeep