linux-kernel - [for-next][PATCH] tracing: Fix synthetic print fmt check for use of __get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201008151849.375ae2b7@gandalf.local.home>
Date:   Thu, 8 Oct 2020 15:18:49 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Ingo Molnar <mingo@...nel.org>, Tom Zanussi <zanussi@...nel.org>,
        Colin Ian King <colin.king@...onical.com>
Subject: [for-next][PATCH] tracing: Fix synthetic print fmt check for use of
 __get_str()

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
for-next

Head SHA1: 9d8739bc05f6d0f3ad21dc5d56f1edfbb9aa7585


Steven Rostedt (VMware) (1):
      tracing: Fix synthetic print fmt check for use of __get_str()

----
 kernel/trace/trace_events_synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---------------------------
commit 9d8739bc05f6d0f3ad21dc5d56f1edfbb9aa7585
Author: Steven Rostedt (VMware) <rostedt@...dmis.org>
Date:   Wed Oct 7 10:34:34 2020 -0400

    tracing: Fix synthetic print fmt check for use of __get_str()
    
    A cut and paste error had the check to use __get_str() test "is_dynamic"
    twice, instead of checking "is_string && is_dynamic".
    
    Link: https://lore.kernel.org/r/d34dccd5-96ba-a2d9-46ea-de8807525deb@canonical.com
    
    Reported-by: Colin Ian King <colin.king@...onical.com>
    Acked-by: Tom Zanussi <zanussi@...nel.org>
    Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
index 742ce5f62d6d..3b2dcc42b8ee 100644
--- a/kernel/trace/trace_events_synth.c
+++ b/kernel/trace/trace_events_synth.c
@@ -491,7 +491,7 @@ static int __set_synth_event_print_fmt(struct synth_event *event,
 	pos += snprintf(buf + pos, LEN_OR_ZERO, "\"");
 
 	for (i = 0; i < event->n_fields; i++) {
-		if (event->fields[i]->is_dynamic &&
+		if (event->fields[i]->is_string &&
 		    event->fields[i]->is_dynamic)
 			pos += snprintf(buf + pos, LEN_OR_ZERO,
 				", __get_str(%s)", event->fields[i]->name);