linux-kernel - Re: [PATCH v6 09/11] mm/memremap_pages: convert to 'struct range'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2a740e2-424c-69ff-45a6-3d71feac5c50@oracle.com>
Date:   Thu, 8 Oct 2020 15:52:14 -0400
From:   boris.ostrovsky@...cle.com
To:     Dan Williams <dan.j.williams@...el.com>, akpm@...ux-foundation.org
Cc:     Paul Mackerras <paulus@...abs.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Vivek Goyal <vgoyal@...hat.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Ira Weiny <ira.weiny@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Jérôme Glisse <jglisse@...hat.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        dave.hansen@...ux.intel.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-nvdimm@...ts.01.org,
        david@...hat.com, joao.m.martins@...cle.com
Subject: Re: [PATCH v6 09/11] mm/memremap_pages: convert to 'struct range'


On 10/6/20 2:55 AM, Dan Williams wrote:
> The 'struct resource' in 'struct dev_pagemap' is only used for holding
> resource span information.  The other fields, 'name', 'flags', 'desc',
> 'parent', 'sibling', and 'child' are all unused wasted space.
>
> This is in preparation for introducing a multi-range extension of
> devm_memremap_pages().
>
> The bulk of this change is unwinding all the places internal to libnvdimm
> that used 'struct resource' unnecessarily, and replacing instances of
> 'struct dev_pagemap'.res with 'struct dev_pagemap'.range.
>
> P2PDMA had a minor usage of the resource flags field, but only to report
> failures with "%pR".  That is replaced with an open coded print of the
> range.
>
> Link: https://lkml.kernel.org/r/159643103173.4062302.768998885691711532.stgit@dwillia2-desk3.amr.corp.intel.com
> Link: https://lkml.kernel.org/r/20200926121402.GA7467@kadam
> Cc: Paul Mackerras <paulus@...abs.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Vishal Verma <vishal.l.verma@...el.com>
> Cc: Vivek Goyal <vgoyal@...hat.com>
> Cc: Dave Jiang <dave.jiang@...el.com>
> Cc: Ben Skeggs <bskeggs@...hat.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Ira Weiny <ira.weiny@...el.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Cc: Juergen Gross <jgross@...e.com>
> Cc: Stefano Stabellini <sstabellini@...nel.org>
> Cc: "Jérôme Glisse" <jglisse@...hat.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>


For Xen bits


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>