linux-kernel - RE: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR07MB552984371C356A6E31D8D116DD0B0@DM6PR07MB5529.namprd07.prod.outlook.com>
Date:   Thu, 8 Oct 2020 03:57:38 +0000
From:   Pawel Laszczak <pawell@...ence.com>
To:     Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Roger Quadros <rogerq@...com>,
        "balbi@...nel.org" <balbi@...nel.org>
CC:     "peter.chen@....com" <peter.chen@....com>,
        "nsekhar@...com" <nsekhar@...com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rahul Kumar <kurahul@...ence.com>
Subject: RE: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

Siergei,

>
>On 10/7/20 11:15 AM, Roger Quadros wrote:
>
>[...]
>>> Patch removes not used variable 'length' from
>>> cdns3_wa2_descmiss_copy_data function.
>>>
>>> Signed-off-by: Pawel Laszczak <pawell@...ence.com>
>>
>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>
>   No "commit" is needed here.

Can you explain why? 

I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version, 
or because it's only warning - not error. 

Am I right ? 

>
>> Acked-by: Roger Quadros <rogerq@...com>
>[...]
>

Regards, 
Pawel