linux-kernel - Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201009045734.GA112189@kroah.com>
Date:   Fri, 9 Oct 2020 06:57:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Harshal Chaudhari <harshalchau04@...il.com>
Cc:     arnd@...db.de, sudipm.mukherjee@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

On Thu, Oct 08, 2020 at 11:57:13PM +0530, Harshal Chaudhari wrote:
> Checking the argument passed to the ioctl is valid
> or not. if not then return -EINVAL.

Along the the comments that Arnd made, this is not the correct value to
be returning from an ioctl when you don't pass in the correct command.

And it doesn't match what your patch says, please be consistent.

And do you have this device to be able to test your changes?

thanks,

greg k-h