linux-kernel - Re: [PATCH 1/6] mm: mmap: fix fput in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201009222509.GC5177@ziepe.ca>
Date:   Fri, 9 Oct 2020 19:25:09 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Christian König <ckoenig.leichtzumerken@...il.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        linaro-mm-sig@...ts.linaro.org, dri-devel@...ts.freedesktop.org,
        linux-media@...r.kernel.org, chris@...is-wilson.co.uk,
        airlied@...hat.com, daniel@...ll.ch, sumit.semwal@...aro.org,
        willy@...radead.org, jhubbard@...dia.com,
        Miaohe Lin <linmiaohe@...wei.com>
Subject: Re: [PATCH 1/6] mm: mmap: fix fput in error path

On Fri, Oct 09, 2020 at 03:04:20PM -0700, Andrew Morton wrote:
> On Fri,  9 Oct 2020 17:03:37 +0200 "Christian König" <ckoenig.leichtzumerken@...il.com> wrote:
> 
> > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..."
> > adds a workaround for a bug in mmap_region.
> > 
> > As the comment states ->mmap() callback can change
> > vma->vm_file and so we might call fput() on the wrong file.
> > 
> > Revert the workaround and proper fix this in mmap_region.
> > 
> 
> Doesn't this patch series address the same thing as
> https://lkml.kernel.org/r/20200916090733.31427-1-linmiaohe@huawei.com?

Same basic issue, looks like both of these patches should be combined
to plug it fully.

Jason