linux-kernel - Re: general protection fault in percpu_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Oct 2020 19:23:02 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     syzbot <syzbot+fd15ff734dace9e16437@...kaller.appspotmail.com>,
        bcrl@...ck.org, hch@....de, linux-aio@...ck.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        ming.lei@...hat.com, syzkaller-bugs@...glegroups.com,
        tj@...nel.org, viro@...iv.linux.org.uk, vkabatov@...hat.com
Subject: Re: general protection fault in percpu_ref_exit

On 10/8/20 2:28 PM, syzbot wrote:
> syzbot has bisected this issue to:
> 
> commit 2b0d3d3e4fcfb19d10f9a82910b8f0f05c56ee3e
> Author: Ming Lei <ming.lei@...hat.com>
> Date:   Thu Oct 1 15:48:41 2020 +0000
> 
>     percpu_ref: reduce memory footprint of percpu_ref in fast path
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=126930d0500000
> start commit:   8b787da7 Add linux-next specific files for 20201007
> git tree:       linux-next
> final oops:     https://syzkaller.appspot.com/x/report.txt?x=116930d0500000
> console output: https://syzkaller.appspot.com/x/log.txt?x=166930d0500000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=aac055e9c8fbd2b8
> dashboard link: https://syzkaller.appspot.com/bug?extid=fd15ff734dace9e16437
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=119a0568500000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=106c0a8b900000
> 
> Reported-by: syzbot+fd15ff734dace9e16437@...kaller.appspotmail.com
> Fixes: 2b0d3d3e4fcf ("percpu_ref: reduce memory footprint of percpu_ref in fast path")
> 
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Ming, this looks like a call of percpu_ref_exit() on a zeroed refs (that
hasn't been initialized). Really a caller error imho, but might make sense
to be a bit safer there.

-- 
Jens Axboe