linux-kernel - Re: [PATCH] page-flags: Remove unused _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b46e93e6-0a26-d989-2888-bd3349fef2b3@redhat.com>
Date:   Fri, 9 Oct 2020 16:16:35 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Miaohe Lin <linmiaohe@...wei.com>, akpm@...ux-foundation.org,
        sfr@...b.auug.org.au, ziy@...dia.com,
        alexander.h.duyck@...ux.intel.com, willy@...radead.org,
        osalvador@...e.de, steven.price@....com, ying.huang@...el.com,
        yang.shi@...ux.alibaba.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] page-flags: Remove unused __[Set|Clear]PagePrivate

On 09.10.20 15:59, Miaohe Lin wrote:
> They are unused anymore.

-EINVAL, sentence does not make sense :)

"They are not used anymore."
"They are unused ."

Reviewed-by: David Hildenbrand <david@...hat.com>

> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  include/linux/page-flags.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 4f6ba9379112..50cbf5e931bc 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -363,8 +363,7 @@ PAGEFLAG(SwapBacked, swapbacked, PF_NO_TAIL)
>   * for its own purposes.
>   * - PG_private and PG_private_2 cause releasepage() and co to be invoked
>   */
> -PAGEFLAG(Private, private, PF_ANY) __SETPAGEFLAG(Private, private, PF_ANY)
> -	__CLEARPAGEFLAG(Private, private, PF_ANY)
> +PAGEFLAG(Private, private, PF_ANY)
>  PAGEFLAG(Private2, private_2, PF_ANY) TESTSCFLAG(Private2, private_2, PF_ANY)
>  PAGEFLAG(OwnerPriv1, owner_priv_1, PF_ANY)
>  	TESTCLEARFLAG(OwnerPriv1, owner_priv_1, PF_ANY)
> 


-- 
Thanks,

David / dhildenb